Though getter/setter methods are commonplace in Java, they are not particularly object oriented (OO). In fact, they can damage your code's maintainability. Moreover, the presence of numerous getter and setter methods is a red flag that the program isn't necessarily well designed from an OO perspective.
This article explains why you shouldn't use getters and setters (and when you can use them) and suggests a design methodology that will help you break out of the getter/setter mentality.
Before I launch into another design-related column (with a provocative title, no less), I want to clarify a few things.
I was flabbergasted by some reader comments that resulted from last month's column, "Why extends Is Evil" (see Talkback on the article's last page). Some people believed I argued that object orientation is bad simply because extends has problems, as if the two concepts are equivalent. That's certainly not what I thought I said, so let me clarify some meta-issues.
This column and last month's article are about design. Design, by nature, is a series of trade-offs. Every choice has a good and bad side, and you make your choice in the context of overall criteria defined by necessity. Good and bad are not absolutes, however. A good decision in one context might be bad in another.
If you don't understand both sides of an issue, you cannot make an intelligent choice; in fact, if you don't understand all the ramifications of your actions, you're not designing at all. You're stumbling in the dark. It's not an accident that every chapter in the Gang of Four's Design Patterns book includes a "Consequences" section that describes when and why using a pattern is inappropriate.
Stating that some language feature or common programming idiom (like accessors) has problems is not the same thing as saying you should never use them under any circumstances. And just because a feature or idiom is commonly used does not mean you should use it either. Uninformed programmers write many programs and simply being employed by Sun Microsystems or Microsoft does not magically improve someone's programming or design abilities. The Java packages contain a lot of great code. But there are also parts of that code I'm sure the authors are embarrassed to admit they wrote.
By the same token, marketing or political incentives often push design idioms. Sometimes programmers make bad decisions, but companies want to promote what the technology can do, so they de-emphasize that the way in which you do it is less than ideal. They make the best of a bad situation. Consequently, you act irresponsibly when you adopt any programming practice simply because "that's the way you're supposed to do things." Many failed Enterprise JavaBeans (EJB) projects prove this principle. EJB-based technology is great technology when used appropriately, but can literally bring down a company if used inappropriately.
| Subject |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
( 1 2 all )
|
|
|
|
|
|
|
|
|
In my point of view...By Anonymous on November 6, 2009, 12:33 pmObjects have properties, and they need to be populated when the object is created. Some are properties the outside world needs to know about, some are internal to...
Reply | Read entire comment
Twisting concepts I readBy Anonymous on November 4, 2009, 5:54 pmTwisting concepts I read your both articles and they are rubish. You say that data abstarction is an important priciple. Let's read together the definition of...
Reply | Read entire comment
This is a programming style not OOPBy Anonymous on October 17, 2009, 8:48 pmObject oriented programming is about creating objects that mimic the real world things you are trying to program business solutions for: a database, a customer,...
Reply | Read entire comment
"I'm sorry, but I don't getBy Anonymous on October 1, 2009, 4:55 pm"I'm sorry, but I don't get your assertion that you don't have UI code..." I agree with that... What if you want to migrate from AWT/Swing if you tie your classes...
Reply | Read entire comment
"What about ORM frameworksBy Anonymous on October 1, 2009, 4:48 pm"What about ORM frameworks like Hibernate and IoC containers like Spring? Even when getters are eliminated in the rest of the code, the data Model is where most...
Reply | Read entire comment
View all comments